[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Glob syntax for svndumpfilter exclude --pattern

From: Branko Čibej <brane_at_apache.org>
Date: Wed, 22 Feb 2017 16:40:01 +0100

On 22.02.2017 15:21, Julian Foad wrote:
> Branko Čibej wrote:
>> On 20.02.2017 17:17, Julian Foad wrote:
>> > Actually, adding the leading slash is not really relevant. The more
>> > general case is that pattern "/trunk/*/README" won't match path
>> > "/trunk/README", as a consequence of not treating slash as special in
>> > paths. A user might well expect it to match, knowing that the pattern
>> > "/trunk//README" *will* match due to our canonicalizing the input
>> > patterns before matching. So there is an inconsistency there.
>>
>> But the user didn't write /trunk//README, she wrote /trunk/*/README
>> which can't be canonicalized to /trunk/README. Remember these are not
>> paths but glob patterns, if we started "canonicalizing" them it'd be --
>> well, interesting -- to try to avoid side effects.
>
> Yes, I know, and I don't propose it.

For the record, I seem to recall that I chose the glob variant that does
not treat / as special precisely because APR's glob flavour does not
provide ** (i.e., the recursive form of * when / is special).

-- Brane
Received on 2017-02-22 16:40:06 CET

This is an archived mail posted to the Subversion Dev mailing list.