[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Glob syntax for svndumpfilter exclude --pattern

From: Julian Foad <julianfoad_at_apache.org>
Date: Mon, 20 Feb 2017 16:17:40 +0000

Branko Čibej wrote:
> On 20.02.2017 11:23, Julian Foad wrote:
>> (I noticed a suboptimal edge case: the above example doesn't match the
>> path '/alpha', because the implementation adds a leading slash to the
>> specified pattern, making '/*/alpha', and then insists on matching
>> both slashes literally.)
> This is a bug.

Actually, adding the leading slash is not really relevant. The more
general case is that pattern "/trunk/*/README" won't match path
"/trunk/README", as a consequence of not treating slash as special in
paths. A user might well expect it to match, knowing that the pattern
"/trunk//README" *will* match due to our canonicalizing the input
patterns before matching. So there is an inconsistency there.

That may not have been intended, but I don't propose we change it now,
because I can't think of any simple change that would be an improvement.

> Everything else is as expected.


- Julian
Received on 2017-02-20 17:17:45 CET

This is an archived mail posted to the Subversion Dev mailing list.