Stefan Sperling wrote on Fri, Feb 17, 2017 at 10:05:23 +0100:
> On Fri, Feb 17, 2017 at 06:43:41AM +0000, Daniel Shahaf wrote:
> > Evgeny Kotkov wrote on Thu, Feb 16, 2017 at 23:55:19 +0300:
> > > > 4) Encourage people to compile alpha/beta/rc with --enable-maintainer-mode.
> > >
> > > 4) seems like an appropriate option to me.
> > >
> > > This is because we only ship the source code, and I think that those who
> > > actually build it should be in charge of enabling or disabling the debug
> > > features.
> > So perhaps we should change the guard from
> > .
> > #ifdef SVN_DEBUG
> > .
> > to
> > .
> > #if defined(SVN_DEBUG) || defined(FSFS_VERIFY_AS_REVISION_BEFORE_CURRENT_PLUS_PLUS)
> > .
> > to make it easier to enable that one feature, without everything else
> > that maintainer mode brings.
> Why are you concerned about everything else that maintainer mode brings?
> I use it all the time and don't notice any problem. Which problems do you
> expect for end users if they use maintainer mode?
a) On general principles, if we want users to test verify-before-commit,
that is not a reason to enable everything else maintainer mode brings.
Kill a fly with a flyswat, not with a cannon.
b) Testing alphas/betas without maintainer mode means the tested code is
closer to what would be compiled from an eventual release. (We've all
seen bugs that happen only in debug builds, or only in release builds.)
I realize that there are also good reason to enable maintainer mode when
testing betas. I don't mean to open that bikeshed; only to point out
that "release build with verify-before-commit" is a reasonable configuration.
> Additional knobs like this cause additional clutter and forces packagers
> to sort through them all and figure out which combo they want.
> Granted, we have a lot of specific feature compile time knobs already,
... which is why we have notes/knobs enumerating them.
> but that in itself is not a good reason for adding more of them.
> I think it is entirely reasonable for us, in general and regardless of this
> particular revision++ check, to ask users to enable maintainer mode when
> testing alpha and betas.
Received on 2017-02-17 13:20:45 CET