Enabling FSFS debug code in alpha releases (was: Re: 1.10.0-alpha1 is up for signing)

A couple of weeks ago we discussed enabling
verify_as_revision_before_current_plus_plus() in the alpha release.

Since that hasn't been done yet, the alpha is now tagged without that
change. (I do not fault him stsp that in the least; the onus was on
proponents of the change to make it happen.)

Can we arrange for a future pre-release (1.10.0-alpha2 or 1.10.0-beta1)
to include this change?

The patch is trivial (attached), so I think this really is about the
mechanics of making the change; for example:

1) enabling it on trunk permanently (and disabling it on stable branches)

2) tagging a wc that has the patch applied

3) committing the patch to a branch and <handwave>arrange for the tag to
incorporate the changes from that branch</handwave>.

Once we resolve this trivial process issue, we'll be able to get user
feedback for verify_as_revision_before_current_plus_plus().

Cheers,

Daniel

Stefan Sperling wrote on Thu, Feb 16, 2017 at 15:26:58 +0100:
> The 1.10.1-alpha1 release is finally up for signing.
>
> Full committers, please get this release from
> https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.
>
> Thank you!
>

[[[
Index: subversion/libsvn_fs_fs/transaction.c
===================================================================
--- subversion/libsvn_fs_fs/transaction.c (revision 1783170)
+++ subversion/libsvn_fs_fs/transaction.c (working copy)
@@ -3338,7 +3342,7 @@ verify_as_revision_before_current_plus_plus(svn_fs
                                             svn_revnum_t new_rev,
                                             apr_pool_t *pool)
 {
-#ifdef SVN_DEBUG
+#if 1
   fs_fs_data_t *ffd = fs->fsap_data;
   svn_fs_t *ft; /* fs++ == ft */
   svn_fs_root_t *root;
]]]
Received on 2017-02-16 15:52:12 CET