[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_config__write

From: Branko ─îibej <brane_at_apache.org>
Date: Mon, 6 Feb 2017 14:12:15 +0100

On 06.02.2017 13:52, Daniel Shahaf wrote:
> svn_config__write() does:
>
> 1346 for (section)
> 1349 {
> 1352 SVN_ERR(svn_stream_printf(stream, section_pool, "\n[%s]\n",
> 1353 section->name));
> 1354
> 1355 for (option)
> 1361 SVN_ERR(svn_stream_printf(stream, options_pool, "%s=%s\n",
> 1362 option->name, option->value));
> 1364 }
>
> Does this need to grow some validation? E.g., check that
> the interpolated strings don't contain '\n' or '='?
>
> Even if the current callsite doesn't care, future callsites might.

It's a private API, so it's never going to be called with some random
user data. I think our test suite is guarantee enough.

-- Brane
Received on 2017-02-06 14:12:25 CET

This is an archived mail posted to the Subversion Dev mailing list.