RE: [PATCH] Issue #4668: Fixing the node key order during svnadmin dump
From: Luke Perkins <lukeperkins_at_epicdgs.us>
Date: Tue, 24 Jan 2017 14:39:06 -0800
Daniel and team,
I appreciate all the consideration for this issue.
I anticipated that there would be some naming adjustments. If someone has a better naming convention, I am all ears.
My vote is that we implement fixed order for the four keys outlined in the JIRA issue 4668 as soon as possible. The switch would activate the current 1.9 scheme. I am always sensitive to the plight of the system administrator who is tasked with deploying SVN repositories in a real world environment. Thus, maintaining 1.9 formatting option is appropriate.
Regarding the SVN dump comparison tool: I am actively reviewing the options on my own machine. I should have a proposal for a new tool to the development team after I have vetted it with my own servers and networks. I am swamped with other engineering activities so this new tool proposal might be a few weeks out.
Julian Foad wrote on Tue, Jan 24, 2017 at 09:51:52 +0000:
The bug is about 1.9 using a different order to 1.8. If we make svnadmin use the 1.8 unconditionally, then 1.9 will use a different order to 1.10, which essentially recreates the bug for other users.
That is: the option serves to allow admins to choose which of the two orders to be consistent with, 1.8 or 1.9.
An alternative to having this option would be a dumpfile comparator that ignores header order differences.
> >What is the verification procedure for implementing this change?
I think Luke was asking about whether a unit test is required. I'll leave it to you guys to decide that, but just point out for Luke that svnadmin_tests.py would be where such a test would live.
This is an archived mail posted to the Subversion Dev mailing list.