[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Svndumpfilter crash on Windows 10

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 19 Jan 2017 07:41:03 +0000

[users_at_->dev@]

Brian Colavito wrote on Wed, Jan 18, 2017 at 21:12:15 -0500:
> This was using the binary bundled with VisualSVN. I got similar results using the one from TortoiseSVN.

Reproduction recipe:

[[[
% svnadmin create r
% svnadmin delrevprop r -r0 svn:date
% svnadmin dump r | svndumpfilter include /
Including prefixes:
   '/'

SVN-fs-dump-format-version: 2

UUID: dfb98010-aee2-4f39-91c0-2fefa7ca3986

* Dumped revision 0.
zsh: done svnadmin dump r |
zsh: segmentation fault svndumpfilter include /
]]]

The fix should be just a matter of not dereferencing 'propstring' in
svn_repos__dump_revision_record() in at the point
SVN_REPOS_DUMPFILE_CONTENT_LENGTH is printed.

However, I won't be investigating this further (no build environment).

Thanks for the report, Brian.

Cheers,

Daniel
Received on 2017-01-19 08:44:57 CET

This is an archived mail posted to the Subversion Dev mailing list.