[moving to dev@]
Matthias Buecher / Germany wrote on Sun, Jan 08, 2017 at 01:57:08 +0100:
> I'm using the attached patch for several years now without any issues
> (also directly in this mail below).
> I want to file this as an issue (patch) and want to make sure that
> everything is fine with this and my patch.
Please do file an issue.
However, note that contrib/ is no longer released; it's not officially
maintained/supported any more. The reason for an issue is so that when
somebody adopts check-mime-type.pl and starts releasing it, they will be
able to take the backlogged issues from our issue tracker.
I also took a quick look at the patch. My most important comment is
that the warning about "may not work" should become a croak(). Also,
the hand-rolled escaping doesn't handle the case of a backslash present
in the input. (And the best way to fix both of these would be to use
a library that abstracts away the platform differences)
Received on 2017-01-12 16:38:31 CET