Re: [PATCH] Recreate test data for Git mirrors

Julian Foad wrote on Wed, Nov 23, 2016 at 21:03:52 +0000:
> Would anyone else care to comment, and review my patch if you think it looks
> good in principle, please?

Thanks for the ping.

Both your approach and Patrick's approach would solve the original
problem, namely, would allow running 'make check' from a git-svn
"working copy". (They would also allow future archeologists to run
'make check' on historical revisions, if we ever reopen INFRA-7524.)

However, I think the "mkdir everything in Python" approach would be
easier to maintain in the long run: that approach results in one
codepath, whereas Patrick's approach results in two codepaths.

My one comment about your patch is that the import tree should be
created under svn-test-work/local_tmp/, rather than under
import_tests_data/; I believe the latter should be considered read-only.

Cheers,

Daniel
Received on 2016-11-24 07:13:13 CET