Re: [PATCH] Fix for SVN 1.8 with sqlite >= 3.12.0 and VS 2005+

On 7/26/2016 12:13 AM, Stefan wrote:
>
> Hi,
>
> building SVN 1.8 using sqlite >= SQLite 3.12.0 (amalgamation) and VS
> 2005+ raises the following error:
>
> [...]\sqlite\sqlite3.c(42437): error C4013: 'rand_s' undefined;
> assuming extern returning int
> [[...]\1.8.16\build\win32\vcnet-vcproj\test_wc_queries.vcxproj]
>
> The issue does not exist in SVN != 1.8 as far as I see. Full details
> available here: http://www.luke1410.de:8090/browse/MAXSVN-58
>
> The attached patch (based on the patch fixing the related issue in
> 1.7) resolves that by moving the sqlite3.c-include section to be first
> include statement in the file.
>
> If it's ok, I'll just add a 1.8 backport branch and nominate it for
> backporting to the 1.8-branch.
>
> Regards,
> Stefan
>
In light of the pending 1.8.16 I'd like to ping on this patch here.
Would be nice to get this in, since it breaks 1.8 builds with latest
sqlite on Windows atm.

Should I create a 1.8-branch with this fix and just add it to 1.8 STATUS
so it can be voted for?

-- 
Regards,
Stefan Hett, Developer/Administrator
EGOSOFT GmbH, Heidestrasse 4, 52146 Würselen, Germany
Tel: +49 2405 4239970, www.egosoft.com
Geschäftsführer: Bernd Lehahn, Handelsregister Aachen HRB 13473