[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1769532 - in /subversion/trunk/subversion: include/private/svn_log.h libsvn_fs_x/fs.h libsvn_subr/log.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 14 Nov 2016 12:21:00 +0100

> -----Original Message-----
> From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> Sent: zondag 13 november 2016 19:20
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1769532 - in /subversion/trunk/subversion:
> include/private/svn_log.h libsvn_fs_x/fs.h libsvn_subr/log.c
>
> Author: stefan2
> Date: Sun Nov 13 18:19:37 2016
> New Revision: 1769532
>
> URL: http://svn.apache.org/viewvc?rev=1769532&view=rev
> Log:
> Fix a couple of integer conversion warnings.
>
> Found by: brane
>
> * subversion/libsvn_fs_x/fs.h
> (svn_fs_x__changes_context): The NEXT element is used with APR arrays,
> so it should be int.
>
> * subversion/include/private/svn_log.h
> (svn_log__list): DIRENT_FLAGS are always 64 bits, so this should be, too.

Why would this always be 64 bit?

svn_types.h has:
/** A combination of all the dirent fields */
#define SVN_DIRENT_ALL ~((apr_uint32_t ) 0)

And svn_client.h's svn_client_list4() (since svn_client_list()) uses apr_uint32_t too.

        Bert
Received on 2016-11-14 12:21:18 CET

This is an archived mail posted to the Subversion Dev mailing list.