[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Correct indentation in svn_client_conflict_text_resolve_by_id

From: Branko Čibej <brane_at_apache.org>
Date: Fri, 11 Nov 2016 15:35:18 +0100

On 10.11.2016 23:37, Daniel Shahaf wrote:
> Stefan wrote on Thu, Nov 10, 2016 at 23:05:18 +0100:
>> On 11/10/2016 10:07, Stefan Sperling wrote:
>>> On Wed, Nov 09, 2016 at 11:21:42PM +0100, Stefan wrote:
>>>> Hi,
>>>> attached is a patch to correct indentation in
>>>> svn_client_conflict_text_resolve_by_id() which was spotted by Evgeny
>>>> (related to the mail thread: "svn commit: r1764902 - in
>>>> /subversion/trunk/subversion: libsvn_client/conflicts.c
>>>> svn/conflict-callbacks.c tests/cmdline/resolve_tests.py").
>>>> Regards,
>>>> Stefan
>>>> [[[
>>>> Following up on r1764902: Corrected indentation.
>> Committed in r1769207 with the corrected name.
> A bit late: generally we prefer verbs to be in the imperative, not in
> the passive; i.e.: s/Corrected/Correct/.

If you're going all grammatical, 'corrected' is also past-tense of
'correct' which means the log message exactly describes what happened to
the code. ++nit-pick: imperative mode would imply that the log message
is saying what needs to be done instead of what was done.

In other words, mine will be vermilion with crimson polka dots, please.

-- Brane
Received on 2016-11-11 15:35:22 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.