[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1767194 - /subversion/trunk/subversion/libsvn_ra_svn/marshal.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 31 Oct 2016 00:19:23 +0000

stefan2_at_apache.org wrote on Sun, Oct 30, 2016 at 22:30:19 -0000:
> Author: stefan2
> Date: Sun Oct 30 22:30:19 2016
> New Revision: 1767194
>
> URL: http://svn.apache.org/viewvc?rev=1767194&view=rev
> Log:
> Close a gap in the ra_svn protocol engine:
> Boolean elements in conditional tuples were not supported but would also not
> occur in the protocol definition. They will in the future, though.
>

The relevant private API docstrings state:

 * 'b' may not appear inside an optional tuple specification; use '3' instead.

Please bring the API docs back in sync with the code. (Not sure whether
it's better to revert the code change and use '3' instead in the caller,
or to update the docs to match the new code.)

Cheers,

Daniel

> * subversion/libsvn_ra_svn/marshal.c
> (vparse_tuple): Handle simple booleans in missing optional parts as well.
>
> Modified:
> subversion/trunk/subversion/libsvn_ra_svn/marshal.c
>
> Modified: subversion/trunk/subversion/libsvn_ra_svn/marshal.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/marshal.c?rev=1767194&r1=1767193&r2=1767194&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_ra_svn/marshal.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_svn/marshal.c Sun Oct 30 22:30:19 2016
> @@ -1671,6 +1671,9 @@ vparse_tuple(const svn_ra_svn__list_t *i
> case '3':
> *va_arg(*ap, svn_tristate_t *) = svn_tristate_unknown;
> break;
> + case 'b':
> + *va_arg(*ap, svn_boolean_t *) = FALSE;
> + break;
> case '(':
> nesting_level++;
> break;
>
>
Received on 2016-10-31 01:21:41 CET

This is an archived mail posted to the Subversion Dev mailing list.