[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1765286 - in /subversion/trunk/subversion: include/svn_xml.h libsvn_subr/xml.c tests/libsvn_subr/xml-test.c

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Mon, 17 Oct 2016 17:37:47 +0300

On 17 October 2016 at 17:29, Bert Huijben <bert_at_qqmail.nl> wrote:
>> -----Original Message-----
>> From: ivan_at_apache.org [mailto:ivan_at_apache.org]
>> Sent: maandag 17 oktober 2016 15:49
>> To: commits_at_subversion.apache.org
>> Subject: svn commit: r1765286 - in /subversion/trunk/subversion:
>> include/svn_xml.h libsvn_subr/xml.c tests/libsvn_subr/xml-test.c
>>
>> Author: ivan
>> Date: Mon Oct 17 13:49:05 2016
>> New Revision: 1765286
>>
>> URL: http://svn.apache.org/viewvc?rev=1765286&view=rev
>> Log:
>> Implement standard lifetime semantics for svn_xml_parser_t: the object will be
>> automatically freed on pool cleanup. But it still can be freed explicitly
>> using svn_xml_free_parser(). It's the same behavior we already have for
>> svn_sqlite__db_t and similar.
>
> Are you planning a new use of this api?
>
Yes. Currently we link Expat XML three times: in libsvn_subr,
libsvn_ra_serf and mod_dontdothat. I'd like to fix it.

> It is currently only used by subversion/libsvn_wc/old-and-busted.c, and I don't
> think we should really spend time optimizing that specific usecase (reading pre 1.4 working copies)
>
Of course I'm aware of this.

-- 
Ivan Zhakov
Received on 2016-10-17 16:38:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.