[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1765088 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/list.c libsvn_repos/repos.c tests/libsvn_repos/repos-test.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 15 Oct 2016 21:59:42 +0000

stefan2_at_apache.org wrote on Sat, Oct 15, 2016 at 15:58:22 -0000:
> +/**
> + * Efficiently list everything within a sub-tree. Specify a glob pattern
> + * to search for specific files and folders.
> + *
> + * Walk the sub-tree starting at @a path under @a root up to the given
> + * @a depth. For each directory entry found, @a receiver will be called
> + * with @a receiver_baton.
> + *
> + * @a path must point to a directory and @a depth must be at least
> + * @c svn_depth_empty.
> + *
> + * Use @a pool for temporary memory allocation.
> + *
> + * @since New in 1.10.
> + */
> +++ subversion/trunk/subversion/libsvn_repos/list.c Sat Oct 15 15:58:22 2016
> @@ -0,0 +1,248 @@
> +svn_error_t *
> +svn_repos_list(svn_fs_root_t *root,
> + const char *path,
> + const char *pattern,
> + svn_depth_t depth,
> + svn_boolean_t path_info_only,
> + svn_repos_authz_func_t authz_read_func,
> + void *authz_read_baton,
> + svn_repos_dirent_receiver_t receiver,
> + void *receiver_baton,
> + svn_cancel_func_t cancel_func,
> + void *cancel_baton,
> + apr_pool_t *pool)
> +{
> + /* Report directory contents if requested. */
> + if (depth > svn_depth_empty)
> + SVN_ERR(do_list(root, path, pattern, svn_depth_infinity,

If depth == svn_depth_files or depth == svn_depth_immediates, the
recursive call is done with depth infinity. That doesn't look right...

> + path_info_only, authz_read_func, authz_read_baton,
> + receiver, receiver_baton, cancel_func, cancel_baton,
> + pool));
> +
> + return SVN_NO_ERROR;
> +}
>
> Propchange: subversion/trunk/subversion/libsvn_repos/list.c
> ------------------------------------------------------------------------------
> svn:eol-style = native
>
Received on 2016-10-16 00:01:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.