[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Reject checkouts to existing directory

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 12 Oct 2016 16:49:55 +0200

> -----Original Message-----
> From: Stefan Sperling [mailto:stsp_at_elego.de]
> Sent: woensdag 12 oktober 2016 16:37
> To: Patrick Steinhardt <patrick.steinhardt_at_elegosoft.com>
> Cc: Subversion <dev_at_subversion.apache.org>
> Subject: Re: [PATCH] Reject checkouts to existing directory
>
> On Wed, Oct 12, 2016 at 04:28:05PM +0200, Patrick Steinhardt wrote:
> > Hi,
> >
> > attached is a patch to reject checkouts to already existing
> > directories when `--force` is not given. This is according to
> > `svn co --help`.
> >
> > [[
> > Reject checkout to existing paths without force
> >
> > * subversion/svn/checkout-cmd.c:
> > - (svn_cl__checkout): Reject checkout to existing directory
> > without --force
> > ]]
>
> Nice catch.
> It's odd that the actual behaviour and help string don't line up.

I'm not sure if the behavior you see is actually a bug. The --force flag is
already used for processing in the update editor and there are cases where I
would like to turn an existing directory in a checkout, while not invoking
that behavior. (I prefer conflicts, over just assuming that every file is
just a modified version of the files already in the directory; the current
behavior triggered by --force)

I can see that you might want to have a warning when there is already a
directory, but I don't think it is the right way to use the --force option
for this.

And then there is the feature that svn checkout is restartable when it fails
after some part of the checkout (just like update)... with this patch
applied that would also stop being supported.

        Bert
Received on 2016-10-12 16:50:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.