RE: [PATCH] Re: ra_local doesn't report post-commit errors
Date: Mon, 19 Sep 2016 09:37:35 +0200
-1 on just returning non errors from the commit info callback and making callers suffer. I added that comment after finding that all callers suffer and there is no way to see the difference, causing all kinds of problems. You can only return errors there to fail fast.
You will cause broken working copies by just returning errors there. All the client side post commit processing will be skipped when the commit function returns an error… That is exactly what you want to do.
Adding that commit info hook on that level after the original api was already fixed for several Subversion versions was an error… we shouldn’t have allowed that callback to return errors in that way. Now where is the time machine to fix it?
That api was designed (around 1.5/1.6) to just store the result and then handling it post commit. In later versions we thought up that it was easier to just print from there…
… but that turns post commit errors in normal commit errors.
I remember that you spend time with me reviewing several bugs caused by this problem and related bugfixes.
Please don’t just reintroduce this very serious problem to ‘not hide a warning’. There are better ways to fix that problem… and not just for your favorite RA layer, ignoring others.
These warnings on the fs layer were designed to be logged server side (e.g. in the apache error log); not to be transferred to the client.
Sent from Mail for Windows 10
From: Daniel Shahaf
Daniel Shahaf wrote on Sat, Sep 17, 2016 at 06:52:44 +0000:
Looking into this, there are two warning comments in the cmdline
One of them is from r857282 (r17208), almost 11 years old now, saying
/* Be very careful with returning errors from this callback as those
It seems to me that:
- If there is a post-commit error, its error chain should be printed to
- svn_cl__print_commit_info() should just return an error if there was
This is an archived mail posted to the Subversion Dev mailing list.