[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs: Segfault when rep line lists the all-zeroes checksum

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 30 Aug 2016 01:05:48 +0000

Stefan Fuhrmann wrote on Mon, Aug 29, 2016 at 22:10:07 +0200:
> On 29.08.2016 18:57, Daniel Shahaf wrote:
> >Line 801 sets CHECKSUM to NULL (as promised by svn_checksum_parse_hex()'s
> >docstring), line 803 dereferences it unconditionally.
> I vaguely remember that we use(d) all-0 checksums
> as a 'no checksum' indicator. There may have been
> some mix-up when rep structure got flattened.

The all-zeroes checksum compares equal to any other checksum.

> >I'm not aware of any way to create such text:/props: lines via the API,
> >but they're useful when editing revision files by hand, and in any case
> >invalid on-disk data should not cause segfaults.
> I'll look into this after the current APR and FSFS fixes
> for svnadmin pack are completed.

Thanks!

> Should not be too difficult to figure out the correct behaviour.
>
> -- Stefan^2.

Cheers,

Daniel
Received on 2016-08-30 03:06:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.