[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] detect apr-bin folder on Windows when integrated in httpd/src - v2

From: Stefan <luke1410_at_posteo.de>
Date: Wed, 27 Jul 2016 01:21:03 +0200

On 7/26/2016 11:25, Stefan Hett wrote:
> Hi,
>
> On 7/26/2016 1:01 AM, Stefan wrote:
>> Hi,
>>
>> the attached patch adds detction of the bin-directory location inside
>> httpd, which is the default location for apr binaries, if apr is
>> integrated in httpd/srclib rather than a stand alone project.
>>
>> The patch would apply to trunk and 1.9.
> I'm taking back this proposed patch for the time being. Found out that
> the library file detection code also needs some tweaking to detect the
> proper apr-library file location. I'll come up with a different patch
> proposal later (not sure whether that will be today though).
Attached is a revised version of the patch. In addition to adding
support to detect apr binaries in httpd's binary directory, it also adds
the corresponding support to detect library files in httpd's library
directory.
It also cleans up the order/approach how apr binary/library directories
are detected ultimately fixing several edge cases which previously would
have resulted in incorrectly set directories.

[[
Add detection support for APR library/binary files when APR is built as part
of Apache httpd and resolve a couple of further edge cases in APR's
directory
detection code.

* build/generator/gen_win_dependencies.py
  (_find_apr): consistently initialize variables in all cases, add detection
               for lib and bin folders in httpd_path if specified, use
common
               approach to determine directories independent of static or
               shared apr usage, add missing checks to whether directories
               really exist and contain the required library files
]]

Regards,
Stefan

Received on 2016-07-27 01:21:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.