RE: svn commit: r1751207 - in /subversion/branches/1.9.x: ./ STATUS subversion/libsvn_subr/win32_crashrpt.c

> -----Original Message-----
> From: Evgeny Kotkov [mailto:evgeny.kotkov_at_visualsvn.com]
> Sent: donderdag 7 juli 2016 19:02
> To: Bert Huijben <bert_at_qqmail.nl>
> Cc: Subversion Development <dev_at_subversion.apache.org>
> Subject: Re: svn commit: r1751207 - in /subversion/branches/1.9.x: ./ STATUS
> subversion/libsvn_subr/win32_crashrpt.c
>
> Bert Huijben <bert_at_qqmail.nl> writes:
>
> >> #if defined(_M_IX86)
> >> -#define FORMAT_PTR "0x%08x"
> >> +#define FORMAT_PTR "0x%08Ix"
> >> #elif defined(_M_X64)
> >> -#define FORMAT_PTR "0x%016I64x"
> >> +#define FORMAT_PTR "0x%016Ix"
> >> #endif

My comments would have applied if I had correctly noticed that you removed the entire "I64" prefix.. But you actually left the "I" prefix, which is a good change.

Sorry for the confusion,

        Bert

For others:
See https://msdn.microsoft.com/en-us/library/tcxf1dw6.aspx for the documentation of the Visual C++ specific prefixes.
"I" is explicitly size_t and/or ptrdiff_t sized.
Received on 2016-07-08 13:44:01 CEST