[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1743556 - /subversion/trunk/build/run_tests.py

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Fri, 13 May 2016 01:00:11 +0300

Stefan Fuhrmann <stefan2_at_apache.org> writes:

> TestHarness._run_test): The log is binary data, so write byte strings
> to it.

[...]

> if self.opts.list_tests:
> - log.write('LISTING: %s\n' % progbase)
> + log.write(('LISTING: %s\n' % progbase).encode())
> else:
> - log.write('START: %s\n' % progbase)
> + log.write(('START: %s\n' % progbase).encode())

Hm, do these log.write() calls always expect bytes? I see that `log'
can be set to two different values, as per run_tests.py:880:

    if self.log:
      log = self.log
    else:
      log = sys.stdout # with --log-to-stdout

And sys.stdout.write() works with strings, so this probably won't work
if tests are run with the --log-to-stdout option.

Regards,
Evgeny Kotkov
Received on 2016-05-13 00:00:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.