[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Improve svn warning/error message to faciliate troubleshooting

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 11 May 2016 16:21:42 +0000

[moving to dev@, please drop users@ on followups]

Cosmere Infahm wrote on Wed, May 11, 2016 at 14:40:53 +0200:
> Could you please improve the warning/error to include the external involved
> so that troubleshooting is easier?

I think this patch will do the trick:

Index: subversion/libsvn_client/externals.c
--- subversion/libsvn_client/externals.c (revision 1743389)
+++ subversion/libsvn_client/externals.c (working copy)
@@ -497,8 +497,10 @@ switch_file_external(const char *local_abspath,
     if (!svn_dirent_is_ancestor(wcroot_abspath, def_dir_abspath))
         return svn_error_createf(
                         SVN_ERR_WC_BAD_PATH, NULL,
- _("Cannot insert a file external defined on '%s' "
+ _("Cannot insert a file external '%s' defined on '%s' "
                           "into the working copy '%s'."),
+ svn_dirent_local_style(local_abspath,
+ scratch_pool),

I don't have time to check if it passes tests, though. I'd be glad if
someone else could pick it up...


(Finding the code location generating the error message isn't black
magic; I simply grepped subversion/po/de.po for the error message.)
Received on 2016-05-11 18:28:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.