Re: svn commit: r1743183 - in /subversion/trunk/subversion/tests/cmdline: svnrdump_tests.py svntest/actions.py svntest/main.py svntest/sandbox.py svntest/verify.py svntest/wc.py

On 10.05.2016 17:26, Evgeny Kotkov wrote:
> Stefan Fuhrmann <stefan2_at_apache.org> writes:
>
>> * subversion/tests/cmdline/svntest/actions.py
>> (run_and_verify_dump): If we accept any output, "None" is the better
>> option as it works with both Python versions.
> [...]
>
>> exit_code, output, errput = run_and_verify_svnadmin(
>> - verify.AnyOutput, [],
>> + None, [],
>> 'dump', '--quiet', repo_dir, *args)
> None and AnyOutput aren't the same, since AnyOutput guards against
> unexpected empty output.
>
> Are we okay with this behavior change for compatibility purposes?

I'm pretty sure definitely not. Why wouldn't verify.AnyOutput work with
both Python versions? It's our code after all.

-- Brane
Received on 2016-05-10 17:29:17 CEST