[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1736357 - in /subversion/trunk: subversion/include/ subversion/libsvn_fs_fs/ subversion/svnadmin/ subversion/tests/cmdline/ tools/client-side/

From: Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>
Date: Fri, 25 Mar 2016 14:01:05 +0300

Ivan Zhakov <ivan_at_apache.org> writes:

>> fs_fs_data_t *ffd = apr_pcalloc(fs->pool, sizeof(*ffd));
>> ffd->use_log_addressing = FALSE;
>> ffd->revprop_prefix = 0;
>> + ffd->flush_to_disk = FALSE;
>
> I think would be more safe to initialize FLUSH_TO_DISK to TRUE to
> match old behavior and prevent possible mistakes in future when some
> other codepath will initialize_fs_struct() without calling
> read_global_config().

Agreed, will do.

>> SVN_ERR(svn_fs_fs__move_into_place(tmp_path, final_path, perms_reference,
>> - pool));
>> + TRUE, pool));
>
> Why ffd->flush_to_disk() is not used here? As far I remember
> revprops-only loading from dump is one of the use case and we already
> have optimized codepath for them.

My intent was not to change more calling sites than necessary. However, in
this particular case that's probably an oversight, at least from the point of
anyone using SVN_FS_CONFIG_NO_FLUSH_TO_DISK.

I'll update this call, and will also add the --no-flush-to-disk option to
the `svnadmin load-revprops' subcommand, since it makes sense there
as well.

Thanks,
Evgeny Kotkov
Received on 2016-03-25 12:01:36 CET

This is an archived mail posted to the Subversion Dev mailing list.