[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for access violation in svn_fs__path_valid()

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 07 Feb 2016 00:22:06 +0000

Stefan wrote on Mon, Feb 01, 2016 at 00:34:32 +0100:
> +++ fs-loader.c (working copy)
> @@ -461,7 +461,8 @@
> if (! svn_utf__cstring_is_valid(path))
> {
> return svn_error_createf(SVN_ERR_FS_PATH_SYNTAX, NULL,
> - _("Path '%s' is not in UTF-8"), path);
> + _("Path '%s' is not in UTF-8"),
> + path ? path : "NULL");

Is this actually a problem? svn_error_createf() uses apr_pvsprintf()
which (by code inspection) accepts NULL here.
Received on 2016-02-07 01:22:07 CET

This is an archived mail posted to the Subversion Dev mailing list.