[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1723882 - /subversion/trunk/subversion/tests/libsvn_ra/ra-test.c

From: Ivan Zhakov <ivan_at_apache.org>
Date: Sun, 31 Jan 2016 20:23:50 +0300

On 27 January 2016 at 15:02, Bert Huijben <bert_at_qqmail.nl> wrote:
>> -----Original Message-----
>> From: ivan_at_apache.org [mailto:ivan_at_apache.org]
>> Sent: zaterdag 9 januari 2016 22:51
>> To: commits_at_subversion.apache.org
>> Subject: svn commit: r1723882 -
>> /subversion/trunk/subversion/tests/libsvn_ra/ra-test.c
>>
>> Author: ivan
>> Date: Sat Jan 9 21:50:33 2016
>> New Revision: 1723882
>>
>> URL: http://svn.apache.org/viewvc?rev=1723882&view=rev
>> Log:
>> Follow-up to r1723865: Relax check in newly added test to copy with known
>> problem in ra_serf.
>>
>> * subversion/tests/libsvn_ra/ra-test.c
>> (get_dir_test): Do not check DIRENT->SIZE due known problem in ra_serf.
>> This
>> test for different bug.
>
> Wasn't it easier to 'just' fix ra_serf here?
>
I've tried, but I didn't have enough time for proper fix that time.

> If I remember correctly serf always retrieves the node kind on retrieved
> nodes, so this shouldn't be hard to fix.
>
I didn't want create dependency on that fact that we always retrieve
node kind. Also DAV properties received in random order, so
resource-type property can be parsed after we parse content-length
property.

-- 
Ivan Zhakov
Received on 2016-01-31 18:24:20 CET

This is an archived mail posted to the Subversion Dev mailing list.