RE: svn commit: r1723876 - in /subversion/branches/fs-node-api/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs/node_compat.c libsvn_fs_fs/node.c
From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 27 Jan 2016 13:07:28 +0100
See inline review below of a minor issue I found when this was committed, but didn't mail about then.
The more interesting question is: what is the status of this branch?
I would like to see this merged to trunk, unless there are some new problems.
> -----Original Message-----
I would say the relation is +-:
Fs -> root -> node.
In that case I would say the node should hold a pointer to root (which already holds a pointer to fs).
Why add a direct pointer 2 levels up, when the step via root is more obvious and probably already available.
(This is all about the member variable... I don't see a problem with the accessor function. It might not be needed later on after more cleanup as callers most likely already have all/most these pointers itself)
This is an archived mail posted to the Subversion Dev mailing list.