[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] improved behaviour of tools/backup/hot-backup.py

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 21 Dec 2015 15:23:15 +0000

On Mon, Dec 21, 2015, at 15:16, Bert Huijben wrote:
>
>
> > -----Original Message-----
> > From: Daniel Shahaf [mailto:d.s_at_daniel.shahaf.name]
> > Sent: maandag 21 december 2015 15:58
> > To: Roberto Reale <roberto.reale82_at_gmail.com>
> > Cc: Philip Martin <philip.martin_at_wandisco.com>;
> > dev_at_subversion.apache.org
> > Subject: Re: [PATCH] improved behaviour of tools/backup/hot-backup.py
>
> >
> > I think (3) should fall back to $REPOS_DIR/db/fs-type (which is
> > guaranteed to exist) rather than to umask. (The umask has the right
> > dimension — permission bits — but using it might surprise users.)
>
> Are you sure this 'must exist'?
>
> When I accidentally tried to use a wrong directory some weeks ago (while
> working on libsvn_fs_git) I found that when that file is missing we assume
> that the filesystem is BDB.

Without checking the code, I suspect you're right, and that file only exists
for repositories created by svn 1.1 or later...

Good catch :-)

Daniel
Received on 2015-12-21 16:23:29 CET

This is an archived mail posted to the Subversion Dev mailing list.