Re: 1.8.15 and 1.9.3

"Bert Huijben" <bert_at_qqmail.nl> writes:

>> -----Original Message-----
>> From: Evgeny Kotkov [mailto:evgeny.kotkov_at_visualsvn.com]
>> Sent: maandag 7 december 2015 18:54
>> To: Subversion Development <dev_at_subversion.apache.org>
>> Subject: Re: 1.8.15 and 1.9.3
>
>
>> As for fixing the problem, I think that we could do something like this:
>> [[[
>> Index: subversion/mod_dav_svn/status.c
>> ==========================================================
>> =========
>> --- subversion/mod_dav_svn/status.c (revision 1718265)
>> +++ subversion/mod_dav_svn/status.c (working copy)
>> @@ -47,6 +47,10 @@
>> #endif
>> #include "svn_private_config.h"
>>
>> +#ifdef HAVE_UNISTD_H
>> +#include <unistd.h> /* For getpid() */
>> +#endif
>> +
>> #ifndef DEFAULT_TIME_FORMAT
>> #define DEFAULT_TIME_FORMAT "%Y-%m-%d %H:%M:%S %Z"
>> #endif
>> @@ -96,7 +100,6 @@ int dav_svn__status(request_rec *r)
>> the request. Ideally we would iterate over all processes but that
>> would need some MPM support, so we settle for simply showing the
>> process ID. */
>> -#include <unistd.h>
>> ap_rprintf(r, "<dt>Server process id: %d</dt>\n", (int)getpid());
>> #endif
>>
>> ]]]
>
> I would be +1 on applying this patch under the obvious fix rule.

I've applied a patch like this to trunk, r1718484 and I'm +1 on merging
to 1.9.

-- 
Philip Martin
WANdisco