[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1716548 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 26 Nov 2015 20:32:10 +0100

> -----Original Message-----
> From: Philip Martin [mailto:philip_at_codematters.co.uk]
> Sent: donderdag 26 november 2015 19:37
> To: Bert Huijben <bert_at_qqmail.nl>
> Cc: 'Branko ─îibej' <brane_at_apache.org>; dev_at_subversion.apache.org
> Subject: Re: svn commit: r1716548 -
> /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c
>
> Philip Martin <philip.martin_at_wandisco.com> writes:
>
> > Philip Martin <philip.martin_at_wandisco.com> writes:
> >
> >> I suppose one way to fix this would be to ensure that every BDB revision
> >> generates a new node-revision-id.
> >
> > To do this we make '/' mutable either when creating the txn, or when
> > commiting the txn. Patches to do both below. Not sure which one is
> > best.
>
> Seems like this behaviour had been observed in the past, with one of my
> patches we also need to stop special-casing BDB in ra-tests:
>
> Index: subversion/tests/libsvn_ra/ra-test.c
> ==========================================================
> =========
> --- subversion/tests/libsvn_ra/ra-test.c (revision 1716725)
> +++ subversion/tests/libsvn_ra/ra-test.c (working copy)
> @@ -1606,12 +1606,7 @@ commit_empty_last_change(const
> svn_test_opts_t *op
> SVN_TEST_ASSERT(dirent != NULL);
> SVN_TEST_STRING_ASSERT(dirent->last_author, "jrandom");
>
> - /* BDB only updates last_changed on the repos_root when there is an
> - actual change. Our other filesystems handle this differently */
> - if (!opts->fs_type || !strcasecmp(opts->fs_type, "BDB"))
> - SVN_TEST_ASSERT(dirent->created_rev == 1);
> - else
> - SVN_TEST_ASSERT(dirent->created_rev == 2);
> + SVN_TEST_ASSERT(dirent->created_rev == 2);
>
> return SVN_NO_ERROR;
> }

I added this specific test early this morning/today in r1716579, as part of verifying if this behavior was BDB or ra_serf+BDB specific.

Feel free to change it :-)

        Bert
Received on 2015-11-26 20:32:36 CET

This is an archived mail posted to the Subversion Dev mailing list.