[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix modification of nil value in Ruby test suite

From: James McCoy <jamessan_at_debian.org>
Date: Mon, 16 Nov 2015 21:07:58 -0500

On Sun, Nov 08, 2015 at 11:26:07PM -0500, James McCoy wrote:
> The attached patch makes the Ruby 2.2 test suite failure I mentioned in
> [0] go away, but this is all code I'm pretty unfamiliar with.
>
> https://mail-archives.apache.org/mod_mbox/subversion-dev/201511.mbox/ajax/%3C20151108030937.GC8248%40freya.jamessan.com%3E
>
> [[[
> Create a new Ruby Object instead of attempting to modify nil.
>
> Starting in Ruby 2.2, the nil, true, and false objects are frozen. This
> was causing test_repos.rb's test_load to fail due to calling
> "repos.load_fs(nil)". This results in svn_swig_rb_make_stream trying to
> attributes on nil, which isn't allowed.
>
> * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c:
> (svn_swig_rb_make_stream): Create a new Object if the given io is nil.
> Also call svn_swig_rb_get_pool in order to deduplicate some
> pool-handling code.
> ]]]

Ping?

Cheers,

-- 
James
GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <jamessan_at_debian.org>
Received on 2015-11-17 03:14:43 CET

This is an archived mail posted to the Subversion Dev mailing list.