[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1714181 - /subversion/branches/move-tracking-2/subversion/tests/cmdline/svntest/main.py

From: Bert Huijben <bert_at_qqmail.nl>
Date: Sat, 14 Nov 2015 13:32:36 +0100

> -----Original Message-----
> From: julianfoad_at_apache.org [mailto:julianfoad_at_apache.org]
> Sent: vrijdag 13 november 2015 11:43
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1714181 - /subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py
>
> Author: julianfoad
> Date: Fri Nov 13 10:42:40 2015
> New Revision: 1714181
>
> URL: http://svn.apache.org/viewvc?rev=1714181&view=rev
> Log:
> On the 'move-tracking-2' branch: Let the test suite read the output from
> 'svnmover' in normal text mode, to normalize line endings on Windows, to
> fix a failure of svnmover_tests 11 on Windows.
>
> * subversion/tests/cmdline/svntest/main.py
> (run_svnmover): Don't use 'binary' mode.
>
> Modified:
> subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py
>
> Modified: subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py
> URL: http://svn.apache.org/viewvc/subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py?rev=1714181&r1=1714180&r2=
> 1714181&view=diff
> ==========================================================
> ====================
> --- subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py (original)
> +++ subversion/branches/move-tracking-
> 2/subversion/tests/cmdline/svntest/main.py Fri Nov 13 10:42:40 2015
> @@ -777,7 +777,7 @@ def run_svnversion(*varargs):
> def run_svnmover(*varargs):
> """Run svnmover with VARARGS, returns exit code as int; stdout, stderr as
> list of lines (including line terminators). Use binary mode for output."""
> - return run_command(svnmover_binary, 1, True,
> + return run_command(svnmover_binary, 1, False,
> *(_with_auth(_with_config_dir(varargs))))

You missed changing the comment here that documents that you explicitly use binary output.

        Bert
Received on 2015-11-14 13:33:08 CET

This is an archived mail posted to the Subversion Dev mailing list.