[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1713980 [4/6] - in /subversion/branches/move-tracking-2/subversion: include/private/ libsvn_client/ libsvn_delta/ libsvn_ra/ libsvn_ra_local/ libsvn_repos/ libsvn_wc/ svnmover/

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 12 Nov 2015 17:32:37 -0600

Oh! I missed the static. ... then I guess dropping the prefix altogether
would be the correct "fix". ??

On Thu, Nov 12, 2015 at 4:38 PM, Julian Foad <julianfoad_at_gmail.com> wrote:

> Well spotted, thanks. I didn't find this as it's a local name (static
> func), although I did catch a couple of other such cases. Will fix.
>
> - Julian
>
> On 12 November 2015 at 16:54, Greg Stein <gstein_at_gmail.com> wrote:
> > On Thu, Nov 12, 2015 at 2:59 AM, <julianfoad_at_apache.org> wrote:
> >>...
> >>
> >> +++ subversion/branches/move-tracking-2/subversion/libsvn_ra/ra_loader.c
> >> Thu Nov 12 08:59:57 2015
> >> @@ -679,8 +679,8 @@ write_rev_prop(svn_ra_session_t *ra_sess
> >> * branch-tracking metadata from the repository into it.
> >> */
> >> static svn_error_t *
> >> -svn_branch_revision_fetch_info(svn_branch_txn_t **txn_p,
> >> - svn_branch_repos_t *repos,
> >> +svn_branch_revision_fetch_info(svn_branch__txn_t **txn_p,
> >
> >
> > Seems you've missed a class of renames. Shouldn't this function name be
> > renamed, too?
> >
> >>...
> >
> > Cheers,
> > -g
> >
>
Received on 2015-11-13 00:32:46 CET

This is an archived mail posted to the Subversion Dev mailing list.