[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1712600 - /subversion/trunk/subversion/include/svn_fs.h

From: Julian Foad <julianfoad_at_gmail.com>
Date: Thu, 5 Nov 2015 17:31:15 +0000

Bert Huijben wrote:
>> Author: julianfoad
>> URL: http://svn.apache.org/viewvc?rev=1712600&view=rev
>> Log:
>> * subversion/include/svn_fs.h
>> (svn_fs_txns group): Remove an obsolete comment about transaction names.
>> It described a naming scheme introduced in r865504 and removed in r865943.
[...]
>> *
>> * The Subversion filesystem will make a best effort to not reuse
>> - * transaction names. The Berkeley DB backend generates transaction
>> - * names using a sequence, or a counter, which is stored in the BDB
>> + * transaction names. The BDB and FSFS backends generate transaction
>> + * names using a sequence, or a counter, which is stored in the
>> * database. Each new transaction increments the counter. The
>> * current value of the counter is not serialized into a filesystem
>> * dump file, so dumping and restoring the repository will reset the
>> - * sequence and reuse transaction names. The FSFS backend generates a
>> - * transaction name using the hostname, process ID and current time in
>> - * microseconds since 00:00:00 January 1, 1970 UTC. So it is
>> - * extremely unlikely that a transaction name will be reused.
>> + * sequence and reuse transaction names.
>
> I would have said it 'may' reuse transaction names.
>
> I don't think we promise that they will actually be reused or not. And perhaps the format may change again in the future.

Good point. r1712828.

- Julian

- Julian
Received on 2015-11-05 18:31:39 CET

This is an archived mail posted to the Subversion Dev mailing list.