[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: NFS performance regression in 1.9

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 23 Oct 2015 12:35:30 +0100

Branko Čibej <brane_at_apache.org> writes:

> On 16.10.2015 13:14, Philip Martin wrote:
>> Philip Martin <philip.martin_at_wandisco.com> writes:
>>> "Bert Huijben" <bert_at_qqmail.nl> writes:
>>>> I'm not able to answer all that, but I do know that your change will
>>>> slow Subversion down on Samba shares as used from Windows systems with
>>>> that flag. And once one user used it in that way it will stay slow
>>>> because the journal mode is stored in the database.
>>>> I don't think just touching a working copy with a client should ever
>>>> have such an effect on a working copy.
>>> The journal mode is set to TRUNCATE every time we open the database,
>>> that doesn't change with my patch. Are you saying that TRUNCATE will be
>>> ignored after some previous connection uses DELETE?
>> The documentation explicitly states that journal_mode=WAL stays in
>> effect for later connections, but doesn't say the same for the other
>> modes:
> I think that means "for later concurrent connections to the database",
> meaning until the last process closes it. That would make sense, because
> you can't combine WAL mode with either truncate or delete at the same time.

I've committed this change and proposed it for 1.9. It only affects
people using exclusive-locking mode working copies and I don't believe
there are any compatibility problems. It goes some way to restoring the
1.9 performance on remote disks.

Philip Martin
Received on 2015-10-23 13:35:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.