[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1707196 - /subversion/trunk/subversion/libsvn_subr/stream.c

From: Julian Foad <julianfoad_at_gmail.com>
Date: Fri, 23 Oct 2015 11:13:50 +0100

On 22 October 2015, Ivan Zhakov wrote:
> On 19 October 2015, Ivan Zhakov wrote:
>> [[[
>> Revv svn_string_from_stream() function and share implementation with
>> svn_stringbuf_from_stream().
>>
>> Suggested by: julianf
[...]
>> ]]]
>>
> Committed in r1710065.
>
>> [[[
>> * subversion/libsvn_subr/stream.c
>> (svn_stringbuf_from_stream): Optimize memory usage a bit and avoid
>> svn_stream_read_full() call once we got partial read.
>> ]]]
>>
> Committed in r1710066.

OK, looks good. (I haven't reviewed the implementation in detail, yet.)

Two more things:

1. The doc string should explain len_hint in the caller's terms. The
doc strings also differ in other unnecessary respects. I propose the
attached documentation patch.

2. The _string and _stringbuf function declarations still differ in
that only svn_string_from_stream2() takes a scratch pool. The current
implementation doesn't use it. We should unify them. Which is best,
taking a scratch pool or not?

Stefan Fuhrmann wrote earlier:
> Maybe get rid of the scratch_pool because we won't use it nor do any of the current
> callers care.

In the absence of any other argument, I would accept that argument and
remove the scratch pool.

- Julian

Received on 2015-10-23 12:14:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.