[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Merge ra-reuse-session branch to trunk or not?

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Sun, 20 Sep 2015 00:07:47 +0200

On 19 September 2015 at 21:17, Bert Huijben <bert_at_qqmail.nl> wrote:
> You wouldn't be able to check the id of the old auth baton once the pool is
> cleaned...
>
I can save old auth baton id in cache_entry once I pass it to
svn_ra_open4() and compare it to the current value in
svn_client_ctx_t.

[..]

> It is possible to attach a pool cleanup handler to see when the auth baton
> is cleared, but I don't like that solution either.
>
I considered this approach, but decided even didn't list it as an
option since it's very fragile and introduce complex dependencies
between objects.

> I agree with Ivan: We should check if the javahl trickery is valid. (We can
> fix javahl of course, but perhaps other users do the same thing)
>
> We probably never described limitations...
>
Exactly. Proper solution would be to expose this limitation as part of
our API by accepting AUTH_BATON and TUNNEL_FUNC as parameter for
svn_client_context_create() function and never expose it in
svn_client_ctx2_t. But this will require to revv all svn_client_*()
functions. I'm not sure that it worth the effort, but I can do it if
everybody agree that this is good and right thing.

-- 
Ivan Zhakov
Received on 2015-09-20 00:08:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.