[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: start-commit hook client capabilities - mergeinfo only?

From: Branko Čibej <brane_at_apache.org>
Date: Tue, 15 Sep 2015 10:51:46 +0200

[from users@]

On 15.09.2015 05:38, Branko Čibej wrote:
> On 15.09.2015 00:38, Brett Randall wrote:
>> I have these versions:
>>
>> Client: svn, version 1.8.8 (r1568071) with ra_svn, ra_local and ra_serf
>> Server: version 1.8.9 (r1591380) with fs_fs
>> Using protocol https://
>>
>> I created and installed a start-commit hook that echos its third
>> parameter (client capabilities) to a log file, ran a test-commit with
>> the above software, and all that is echoed for client-capabilities is:
>> mergeinfo. The repository access is over https:// .
> I can confirm this happens with file:// and svn://, too.
>
>> Any idea what is going-on here?
> It could be we're confusing repository capabilities vs. client
> capabilities somewhere in the code. In any case, the documentation (and
> the implementation) clearly states we should be seeing client
> capabilities here, so it looks like a bug at first glance.

I've taken a look at the code and apparently we only record the
"mergeinfo" capability, regardless of anything else the client might
send. I have no idea why we do that ... in any case, this is clearly at
odds with the documentation in the hook script template and elsewhere in
the code.

I suppose we should fix the hook docs?

-- Brane
Received on 2015-09-15 10:51:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.