[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1702305 - /subversion/trunk/subversion/libsvn_subr/stream.c

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Thu, 10 Sep 2015 21:06:20 +0200

On Thu, Sep 10, 2015 at 9:00 PM, Bert Huijben <bert_at_qqmail.nl> wrote:

>
>
> > -----Original Message-----
> > From: stefan2_at_apache.org [mailto:stefan2_at_apache.org]
> > Sent: donderdag 10 september 2015 20:14
> > To: commits_at_subversion.apache.org
> > Subject: svn commit: r1702305 -
> > /subversion/trunk/subversion/libsvn_subr/stream.c
> >
> > Author: stefan2
> > Date: Thu Sep 10 18:13:52 2015
> > New Revision: 1702305
> >
> > URL: http://svn.apache.org/r1702305
> > Log:
> > APR file based streams shall not superficially support read or write
> > functions when we know that the APR file itself does not. Instead,
> > they will now return a "not supported" stream error.
> >
> > Note that this check is not perfect for arbitrary APR file handles
> > (may enable more functions than the handle actually supports) but
> > works correctly for our STD* streams and the files opened through
> > our svn_io_* API.
>
> This patch breaks JavaHL's tunnel tests on at least one buildbot.
>
>
> https://ci.apache.org/builders/svn-x64-centos-gcc/builds/277/steps/Test%20bindings%20fsfs%2Bra_serf/logs/stdio
>
> (The JavaHL tests PASS on Windows)
>

Ok. I'll wait for Brane to maybe have a look at it. Could well be
that we uncovered an inconsistency in the bindings.

Otherwise, I'm happy to revert that change. It simply felt like
it belonged with similar changes that were made recently.

-- Stefan^2.
Received on 2015-09-10 21:06:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.