RE: Crash in calculate_repos_relpath()

> -----Original Message-----
> From: Ivan Zhakov [mailto:ivan_at_visualsvn.com]
> Sent: woensdag 9 september 2015 17:23
> To: Bert Huijben <bert_at_qqmail.nl>; dev_at_subversion.apache.org
> Subject: Crash in calculate_repos_relpath()
>
> I was looking to the most reported TortoiseSVN crash reports and found
> many crash in libsvn_wc/update_editor.c:551 in function
> calculate_repos_relpath() due calling to svn_relpath_join() with BASE
> == NULL:
> [[[
> if (old_repos_relpath == NULL)
> {
> SVN_ERR_ASSERT(pb != NULL);
> *new_repos_relpath = svn_relpath_join(pb->new_repos_relpath, name,
> result_pool);
> }
> ]]]

> Bert, do you have any ideas why PB->NEW_REPOS_RELPATH could be NULL?

This error was possible in case an ancestor of the path was skipped, and then a file or directory was added.

Added fix and testcase in r1702198.

        Bert
Received on 2015-09-10 11:44:28 CEST