[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1701317 - in /subversion/trunk/subversion: include/private/svn_ra_svn_private.h libsvn_ra_svn/marshal.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Sat, 5 Sep 2015 02:53:34 +0200

On 04.09.2015 21:17, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Fri Sep 4 19:17:44 2015
> New Revision: 1701317
>
> URL: http://svn.apache.org/r1701317
> Log:
> Finally, make svn_ra_svn__list_t actually a fully typed, ra_svn-specific
> object. Update the creation functions; everything else already "just fits".

How is this code different from using APR arrays, except that the latter
needs a typecast on array item access? As far as I can see, you've
completely duplicated the APR array allocation strategy, including using
two allocations to create the array.

The only significant difference is that capacity is being tracked
outside the svn_ra_svn__list_t structure during the construction of the
list.

Call me dense ... but can you please explain how exactly is this
better/faster than using APR arrays? (I'm not going to mention 'safer'
because it clearly isn't.) Code like this that is apparently meant be an
optimisation of something(?) really should have a bit of an explanatory
comment, IMO.

-- Brane
Received on 2015-09-05 02:53:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.