[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [patch] Fix libsvn_auth_kwallet crash, use-after-free

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 3 Sep 2015 10:35:51 +0200

> -----Original Message-----
> From: James McCoy [mailto:vega.james_at_gmail.com] On Behalf Of James
> McCoy
> Sent: donderdag 3 september 2015 04:00
> To: Bert Huijben <bert_at_qqmail.nl>
> Cc: dev_at_subversion.apache.org
> Subject: Re: [patch] Fix libsvn_auth_kwallet crash, use-after-free

> > Can you verify if the patch in https://svn.apache.org/r1700740 fixes this
> problem?
>
> With the below change, it does:
>
> Index: subversion/libsvn_auth_kwallet/kwallet.cpp
> ================================================================
> ===
> --- subversion/libsvn_auth_kwallet/kwallet.cpp (revision 1700924)
> +++ subversion/libsvn_auth_kwallet/kwallet.cpp (working copy)
> @@ -47,6 +47,7 @@
> #include "svn_auth.h"
> #include "svn_config.h"
> #include "svn_error.h"
> +#include "svn_hash.h"
> #include "svn_io.h"
> #include "svn_pools.h"
> #include "svn_string.h"

Thanks,

Committed this patch in r1700951 and nominated both patches for backporting to 1.9.2.

Thanks,
        Bert
Received on 2015-09-03 10:36:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.