[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bulk copying revprops

From: Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com>
Date: Mon, 31 Aug 2015 20:21:02 +0100

On Sat, Aug 29, 2015 at 3:18 PM, Evgeny Kotkov <evgeny.kotkov_at_visualsvn.com>

> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
> > Because most of the infrastructure for dump-revprops and load-revprops is
> > already in place, I'll give it a go and commit a straightforward
> > implementation.
> As of r1698382, I am seeing a segmentation fault every time I try to use
> svnadmin load-revprops with an existing dump:
> 0000000000000000()
> svnadmin.exe!svn_repos_parse_dumpstream3() Line 501
> svnadmin.exe!svn_repos_load_fs_revprops() Line 1485
> svnadmin.exe!subcommand_load_revprops() Line 1562
> svnadmin.exe!sub_main() Line 2959
> svnadmin.exe!main() Line 2992
> ...

Thanks for the bug report!

> Perhaps the infrastructure isn't exactly ready to be used with null vtable
> entries like svn_repos_parse_fns3_t.new_node_record?

If we allow any type of dump stream to be fed into load-revprops,
the parser apparently requires all callback functions to be non-NULL.
r1700180 fixes that problem.

I committed the failing test for this behavior in r1700035.

That one passes now. I also added a test for dump-revprops so
that new svnadmin subcommands should be covered now.

-- Stefan^2.
Received on 2015-08-31 21:21:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.