[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Review of sizeof usage

From: Branko ─îibej <brane_at_wandisco.com>
Date: Tue, 11 Aug 2015 21:55:48 +0200

On 11.08.2015 17:02, Philip Martin wrote:
> Stefan Fuhrmann <stefan.fuhrmann_at_wandisco.com> writes:
>
>> way we use sizeof. In my opinion, we should take the
>> size of the created or processed variable instead of its
>> type, i.e.
>>
>> abc_t *v = apr_pcalloc(pool, sizeof(*v));
>> apr_hash_set(hash, key, sizeof(*key), y);
>> z = apr_hash_get(hash, key, sizeof(*key));
>>
>> rather than
>>
>> abc_t *v = apr_pcalloc(pool, sizeof(abc_t));
>> apr_hash_set(hash, key, sizeof(key_t), y);
>> z = apr_hash_get(hash, key, sizeof(key_t));
> We have had problems with both styles in the past, so neither is immune
> to bugs. I prefer the explicit type as it is easier to grep.

The explicit type form is more accident-prone than the variable form
because any change requires two modifications in the same statement
instead of one.

-- Brane
Received on 2015-08-11 21:56:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.