[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: The patch-exec branch

From: Branko Čibej <brane_at_wandisco.com>
Date: Sun, 26 Jul 2015 17:50:43 +0200

On 26.07.2015 14:07, Daniel Shahaf wrote:
> danielsh_at_apache.org wrote on Sun, Jul 26, 2015 at 12:01:57 -0000:
>> Author: danielsh
>> Date: Sun Jul 26 12:01:56 2015
>> New Revision: 1692721
>>
>> URL: http://svn.apache.org/r1692721
>> Log:
>> On the patch-exec branch, add BRANCH-README.
>>
>> Added:
>> subversion/branches/patch-exec/BRANCH-README
>>
>> Added: subversion/branches/patch-exec/BRANCH-README
>> URL: http://svn.apache.org/viewvc/subversion/branches/patch-exec/BRANCH-README?rev=1692721&view=auto
>> ==============================================================================
>> --- subversion/branches/patch-exec/BRANCH-README (added)
>> +++ subversion/branches/patch-exec/BRANCH-README Sun Jul 26 12:01:56 2015
>> @@ -0,0 +1,20 @@
>> +This is a feature branch for teaching 'svn patch' to parse
>> + old mode 100644
>> + new mode 100755
>> +lines generated by 'git diff'.
> In a nutshell, the purpose of the branch is to make 'svn patch' set
> svn:exeutable when processing a patch such as:
>
> diff --git a/iota b/iota
> old mode 100644
> new mode 100755
> index 6264577..c3f5d71
> --- a/iota
> +++ b/iota
> @@ -1 +1,2 @@
> ...
>
> The unit tests changes (in parse-diff-test.c and patch_tests.py) give
> a full example of the new functionality.
>
> It seems pretty straightforward so far, but I wanted to see if anyone
> had comments on the idea or the implementation before I took it any
> further.
>
> Basically, does this sound like a good idea, and if so is the
> implementation going in the right direction, etc.
>
> Thanks,
>
> Daniel
>
>> +Steps:
>> +
>> +- [DONE] Implement parse-diff.c support
>> +- [DONE] Implement "make it executable" support, with tests
>> +- [TODO] Implement "make it non-executable" support, with tests
>> +- [TODO] Write tests for adding/remove svn:executable using the normal
>> + 'svn diff' property add/removal syntax
>> +- [TODO] parser: Review handling of modes other than 0644/0755
>> + Consider checking "mode & 0111"
>> +
>> +Optional:
>> +
>> +- [TODO] Should 'svn diff --git' be taught to emit the new form?
>> + (possibly in addition to the stadard propchange form used for all
>> + user properties, for compatibility with released 'svn patch' versions)

It'd be sort of nice if 'svn patch' could apply not just mode changes
but tree changes described in the git diff format.

-- Brane
Received on 2015-07-26 17:50:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.