[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: building SVN trunk on Windows fails on python gen-make.py

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 22 Jun 2015 13:41:30 +0000

[ moved from users@ to dev@; tldr: trunk gen-make.py fails with py3.4/windows ]

Stefan Hett wrote on Mon, Jun 22, 2015 at 15:12:31 +0200:
> >On Mon, Jun 22, 2015 at 12:45 PM, Stefan Hett <stefan_at_egosoft.com> wrote:
> >> File "E:\Python34\lib\encodings\cp1252.py", line 23, in decode return
> >>codecs.charmap_decode(input,self.errors,decoding_table)[0]
> >>UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2116:
> >>character maps to <undefined>
> >Quick shot: perhaps it's related to the Python version. I'm using
> >Python 2.7. Can you try that?
> >
>
> Hi Johan,
>
> thanks for the hint. That indeed seemed to have been the problem.
> Passes through the python script now when using Python 2.7.10.
>
> Regards,
> Stefan

Two things about that error:

1. The file that triggers it is probably
subversion/tests/cmdline/upgrade_tests_data/upgrade_with_externals.tar.bz2
(it has a 0x81 byte at the given offset). It's a binary file so it
shouldn't be fed to a unicode decoder in the first place. It's only
used by some unit tests.

2. I went through autogen.sh/configure on Python 3 on Linux a few weeks
ago and got it to pass. (I don't recall what's the status of the test
suite under py3.) So either this issue is specific to Py3 on Windows,
or I missed something, or the gen-make.py code has changed.

Anyway, gen-make.py shouldn't fail like that. I'd rather it just worked
under py3, but if we can't make it work, we should error out up front if
Python is newer than we support.

Cheers,

Daniel

P.S. If anyone wonders, the command I used was 'xxd -s 2114 -l 5
-g 2 | grep -qw 81'.
Received on 2015-06-22 15:44:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.