[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

From: Branko Čibej <brane_at_wandisco.com>
Date: Wed, 03 Jun 2015 19:53:41 +0200

On 03.06.2015 19:50, Ivan Zhakov wrote:
> On 3 June 2015 at 20:44, Branko Čibej <brane_at_wandisco.com> wrote:
>> On 03.06.2015 19:38, Ivan Zhakov wrote:
>>> On 3 June 2015 at 20:29, Branko Čibej <brane_at_wandisco.com> wrote:
>>>
>>>> An API user who wants an early exit can always trigger the cancel_func
>>>> in her notification handler and get SVN_ERR_CANCELLED in response.
>>>>
>>> The problem that it's could be hard to distinguish summary errors from
>>> repository corruption errors itself for API user.
>> Why? The summary error code (SVN_ERR_REPOS_VERIFY_FAILED) is used in
>> only at the end of a run with keep_going=TRUE iff the FS backend
>> returned an error. It cannot be returned from the FS backend validation
>> functions, so it will never appear in a notification and will never be
>> returned when keep_going=FALSE. In fact, that's the main reason I
>> decided to keep a separate, new error code for this case.
>>
> Is it documented that only SVN_ERR_REPOS_VERIFY_FAILED used for
> summary errors? Do we promise to always return this error code?

If you think we need additional documentation, feel free to add it.

-- Brane
Received on 2015-06-03 19:54:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.