[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

From: Branko Čibej <brane_at_wandisco.com>
Date: Wed, 03 Jun 2015 19:29:35 +0200

On 03.06.2015 17:10, Ivan Zhakov wrote:
> On 3 June 2015 at 17:19, Branko Čibej <brane_at_wandisco.com> wrote:
>> On 03.06.2015 15:31, Ivan Zhakov wrote:

>>> I'm also not sure that we have to return error if we already reported it via notify_func in
>>> svn_repos_verify_fs3().
>>
>> Out notification mechanism cannot replace API consistency. When an API call
>> fails, it must return an svn_error_t; surely you're not proposing that we
>> make an exception for svn_repos_verify_fs3?
>>
> This is depends whether check of corrupted repository is error or not.
> I mean that semantic could be: "please give me all/first corruptions
> in this repository via notify_func".

Hm, well, that would be a different API than what svn_repos_verify_fs3
documents.

An API user who wants an early exit can always trigger the cancel_func
in her notification handler and get SVN_ERR_CANCELLED in response.

-- Brane
Received on 2015-06-03 19:30:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.