[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't remove empty directories when creating repositories (in some cases)

From: Sergey Raevskiy <sergey.raevskiy_at_visualsvn.com>
Date: Tue, 31 Mar 2015 16:31:55 +0300

> Wouldn't it be easier, and a smaller patch, to add a check in
> svn_repos_create that the FS type is valid /before/ creating the
> repository structure? This would also avoid adding yet another public API.

As I understand there is no public API for checking if FS-type is valid and
corresponding FS module is available (for DSO-enabled builds).

Even if we do a preliminary check like that, there are a number of other
errors that could occur during module loading and filesystem creation.
I used 'invalid-fs-type' in test just as simple and predictable way to fail
the filesystem creation.

I agree that it would be better to avoid adding yet another public API, but
svn_io_remove_dir_contents() function might be useful for both Subversion
and third-party public API clients.
Received on 2015-03-31 15:32:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.