[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] On the 'ra-git' branch: update to libgit2 v0.22

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 30 Mar 2015 18:26:52 +0000

Carlos MartĂ­n Nieto wrote on Mon, Mar 30, 2015 at 16:58:57 +0200:
> +++ autogen.sh (working copy)
> - configfile=${LIBTOOL_CONFIG-`cd $ltpath/../share/libtool/config ; pwd`/$file}
> + configfile=${LIBTOOL_CONFIG-$(cd $ltpath/../share/libtool/config ; pwd)}/$file

Is it safe to use $(...)? At least Solaris sh doesn't support it, and
there are only two uses in configure — one is in dead code and one is in
a string only used for error messages. I suppose it would be safer to
retain the `...`.

Also, please use a text/* MIME type for patch attachments, rather than
text/plain.

Looks good otherwise.

Cheers,

Daniel
Received on 2015-03-30 20:29:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.